gap: driver mode hides the level crossings, the one mode a crossing is about #235
Labels
No labels
agent
agent:ci
agent:done
agent:failed
agent:needs-input
agent:refined
agent:refining
agent:running
agent:shipped
agent:skip
autonomous
autopilot
driven
local
plan
proposal
qa
qa-gap
research
retro
ship
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
jeroen/cartopolis#235
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What I did
Followed the layer's three fetch gates into driver mode, having confirmed the layer works
outside it (settled capture over the Peizerweg AHOB,
level_crossings = 3).What happened
Entering driver mode runs
data_layers::apply_minimal_mode, which setsThat is the third of this layer's three gates. In
map_geometry:So a driving run draws no crossing and does not even ask the register for one — and
because
furnitureis part ofDetailWants, the change retears the ring, so thecrossings already standing are taken away at the moment Start is pressed.
What a user would expect
Minimal mode strips scenery so the road reads: buildings, trees, grass, benches, parked
cars, weather. A level crossing is not scenery. It is a road control a driver must stop
at, and it is the one thing on this layer that a driver, specifically, would want to see
coming. Turning it off in Drive is the opposite of what the mode is for — and it is the
only mode in the client where a barrier across the road has a meaning.
The same applies, more weakly, to the altitude fade it inherits: crossings are hidden
above
FURNITURE_FADE_END(450 m) like a bench, though a 7.6 m boom and a pair of mastsare an order of magnitude larger than the objects that band was measured for. Compare
#215, which is the same complaint about the navigation marks.
Where the seam is
crates/cartopolis/src/systems/gui/data_layers.rs::apply_minimal_mode, and the fact thatcrossings deliberately have no toggle of their own
(
docs/notes/prorail-level-crossings.md, "What is not drawn, and why" — "Crossings ridethe existing Furniture toggle, because they are that group's mesh, material and altitude
fade"). Riding the toggle is what makes the group cheap; it is also what hands the
crossings minimal mode's decision about benches. Either they need a gate of their own that
minimal mode leaves alone, or minimal mode needs to keep this part of the furniture group.
Filed from the QA pass on #216 (#230).